View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014971 | MMW 5 | Playback | public | 2018-07-18 12:01 | 2019-02-17 15:25 |
| Reporter | Ludek | Assigned To | |||
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0014971: Auto-update feature with combination of Now Playing Undo causes gaps between tracks to be played | ||||
| Description | In the ticket HPE-275-24630 there is a log indicating that it takes about 30 seconds when the next track starts to play. Seems to be related to auto-update feature implemented by Petr and yes, there is probably a memory leak causing that auto-update on a track property change takes so long. I guess that Now Playing Undo feature could cause the memory leaks? Currently it seems to keep all old tracklists in memory and the auto-update feature has to traverse all the tracklists on each property change. I see two issues here (already discussed with devs via IM previously): 1) Auto-update: It seems very cost and performance consuming operation to traverse all tracklists in memory after every track property change. Petr has already promised to look into it and optimize it. 2) Now playing undo: We should probably change it: a) to limit it to e.g. only 10 undo items b) don't keep the tracklists in memory, but flush them to DB (or disc - persistent.json) and load them again on demand. | ||||
| Additional Information | http://www.mediamonkey.com/forum/viewtopic.php?f=30&t=89851#p445673 HPE-275-24630 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2116 | ||||
|
|
Assigned 2) to Michal, assign 1) to Petr once 2) is implemented (and Petr is back from vacation) |
|
|
2) fixed in build 2116. History is now limited to 10 entries only (could be easily changed, if needed) and auto-update is disabled for lists in history, it is not needed there. There is probably no need to slow undo/redo down by moving all to disk, as track's data is shared among all instances of the track, so it should not be problem to hold 10 playlists there. |
|
|
Fixed |
|
|
Verified 2116 |
|
|
Verified 2160 |
