View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0009450 | MMW v4 | Properties/Auto-Tools | public | 2012-06-21 04:00 | 2012-12-22 01:20 |
| Reporter | rusty | Assigned To | |||
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0.6 | ||||
| Target Version | 4.0.6 | Fixed in Version | 4.0.6 | ||
| Summary | 0009450: Flac: some fields aren't cleared correctly | ||||
| Description | As reported at 0009402, Track Volume tag isn't cleared correctly on deletion. In addition, the Encoder field is sometimes deleted, and sometimes not. This is due to the fact that MM currently includes Encoder (editable) and Vendor--when Encoder is null (non-editable) in the field. The net effect is that users don't know which of these is included, and edits/deletions sometimes work and other times don't (depending on whether Encoder or Vendor is displayed). This should be included in the automated test harness for all fields and for all supported formats. | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1499 | ||||
|
|
Possible solutions to the problem with the Encoder field. 1) Don't display Vendor in that field, and instead add a new non-editable Vendor field in the area below containing non-editable metadata. (note: we could also just get rid of the Vendor info altogether, but this may cause confusion among users). 2) Display the non-editable metadata in a different fashion (e.g. greyed out) |
|
|
Another related things: 1) libvorbis API does not let applications override the Vendor string, so it does not seem to be good idea to delete/change it, it is written only by encoder. 2) there is general problem with deleting replaygain peak value (related to all formats), user can delete track and album volume from track list, but peak value remains in the file. We should delete it in case there is no alubum and track volume value. |
|
|
I think, for now, the best would be to save Encoder to Encoder tag only in case it is different from Vendor. So user delete encoder -> encoder tag is deleted. Vendor will be filled to encoder field in properties dialog, but saving tags will not recreate encoder tag in the file. |
|
|
Track and album volume for FLAC fixed in build 1499. The rest will be defered to 4.1, it is quite risky and need more testing. The solution of Vendor/Encoder: - we will save empty string to Encoder tag in case user deletes encoder field. So if MM reads existing empty encoder field, it will not fill Vendor to encoder field. We will never change Vendor string. |
|
|
Album and track gain fixed in build 1499. The rest is covered by more general issue 0009455. |
|
|
Verified 1615 |
