View Issue Details

IDProjectCategoryView StatusLast Update
0009125MMW v4Burning / Disc Handlingpublic2012-05-23 21:33
ReporterLudek Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0.4Fixed in Version4.0.5 
Summary0009125: AccurateRip 2 support
DescriptionCurrently we supports AccurateRip as [x] Verify ripped tracks option (0006005).

EAC supports also AccurateRip 2 that contains another algorithm for counting CRCs therefore some CDs fails to verify in MediaMonkey.
Additional InformationMore info how to calculate the CRC: http://forum.dbpoweramp.com/showthread.php?20641-AccurateRip-CRC-Calculation
http://www.hydrogenaudio.org/forums/index.php?s=&showtopic=61574&view=findpost&p=772006
TagsNo tags attached.
Fixed in build1480

Relationships

related to 0009122 closedLudek Failure to rip some specific CDs when "verify" is enabled 
child of 0006005 closedLudek AccurateRip for verification of disc rips 

Activities

Ludek

2012-02-17 16:53

developer   ~0030449

Last edited: 2012-02-21 14:24

Fixed in build 1600.

Note that there was no UI change, the workflow is:
ARv1 checksum is compared and if it doesn't match then ARv2 checksum is compared.

Ludek

2012-02-21 14:23

developer   ~0030489

Re-opened, although I implemented the CRC v2 calculation accordingly the resulted checksums are different from EAC's, so there is still something wrong with ARv2 calculation.

Ludek

2012-02-21 23:37

developer   ~0030507

Last edited: 2012-02-22 01:57

Finally I had to completely rework the algorithm to make this work, but there is a performance problem though. We calcs checksums for all possible offsets at once and then we auto-detect the right offset. In case of AR v2 we cannot optimize the algorithm similar way as in case of AR v1 therefore it is slow.

The solution seems to be to add workflow to detect drive offset another way (as EAC and dBpoweramp does) and then use the single offset for calculation.

More details:
http://www.accuraterip.com/driveoffsets.htm
http://home.scarlet.be/spb2267/offsets/offsets.htm
http://blowfish.be/eac/Setup/setup5.html
http://www.dbpoweramp.com/cd-ripper-setup-guide.htm

As you can see from the links, the drive offset detection is quite complex workflow, therefore I used a set of well known offsets, this solution should be sufficient and is used by some other rip apps too (e.g. Morituri). The advantage is no need for an additional UI and we can possibly integrate it into 4.0.4

Ludek

2012-02-22 01:11

developer   ~0030510

Fixed in build 1600.

Ludek

2012-02-23 15:14

developer   ~0030526

Last edited: 2012-02-23 15:14

I merged it also to 4.0.4.1480

Test notes:

The workflow is that the ARv2 is used only if ARv1 CRC doesn't match. So it cannot be tested with old and popular CDs. It can be tested only with the newest and less popular CDs. I tested the CD from the issue 0009122 (user attached image via forum).

The resulted CRCs can be seen in debug log, for CDs that needs to be verified via ARv2 there is:

[2992] AccurateRip - Track 2. - Rip not accurate (confidence 4) arCRC [1fed5505] CRC [7e51eb2f] ARv1
[2992] AccurateRip - Track 2. - rip offset: 697 (confidence 4) CRC [1fed5505] ARv2

and for popular CDs that doesn't need to be verified via ARv2 there is just

[2992] AccurateRip - Track 2. - rip offset: 697 (confidence 200) CRC [7e51eb2f] ARv1

peke

2012-05-23 21:33

developer   ~0031201

Verified 1492