View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007827 | MMW v4 | Collections (Filters) | public | 2011-05-16 17:53 | 2011-09-19 20:30 |
| Reporter | rusty | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 4.0 | ||||
| Target Version | 4.0 | Fixed in Version | 4.0 | ||
| Summary | 0007827: Sharing of / Collection settings is broken | ||||
| Description | 1 Create 'Kids Music' and share settings with 'Music' 2 Enabled / Disable Column Browser to verify that settings are shared 3 Right-click 'Kid's Music' > 'Options' > 'Edit Collection' --> MM shows than 'none' collection settings are shared!! 4 Edit Collection settings for Kids Music via 'Edit Collection' dialog: Add 'Artist' column --> Artist column isn't added to the view (refresh has no effect), and right-clicking on the columns shows 'Artist' column unselected, despite the fact that revisiting the 'Edit collections' dialog shows it as being selected. 5 Edit Collection settings for Music by right clicking on Column 'Artist' --> Artist column appears, in both Music and Kids music, but is _not_ enabled in the Edit Collections dialog. Could it be related to the fact that the field order differs between the Column chooser, and the list of fields in the Edit Collections dialog? | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1399 | ||||
|
|
As Petr pointed out, there's a small problem in collection sharing. Currently it isn't clear which way the initial sharing should go. E.g. if user creates a new collection X and checks that it should share settings with collection A, currently settings of A is overwritten by X. Jiri suggested to show a new confirmation dialog after clicking OK on 'Select Collections to share settings' dialog: Which configuration do you prefer? {this text could be made more descriptive} [[Current collection (name)]] [Music] [Music Video] [Cancel] where buttons will represent the selected collections. Note that this dialog doesn't have to be shown everytime, just when it's unclear which way to make the initial copy of settings. Assigning to Rusty to review the idea and UI. |
|
|
Here are 2 possible approaches, both of which use only existing strings. I prefer the first as it doesn't require a popup dialog, and is more understandable within the context of the 'Select Collections to share settings' dialog. 1) Config panel within the existing "Select Collections to share settings" dialog (the text appears below the list of Collections, whenever a new sharing relationship is added to the <current collection>): Use: (or Default View Settings) (o) <current collection> (Overwrite: <collection A>, <collection B>) ( ) <collection A>, <collection B> (Ignore: <current collection>) 2) Popup dialog approach (the dialog appears whenever a new sharing relationship is added to the <current collection>) Settings (or Default View Settings) ----------------- Do you want to overwrite <collection A>, <collection B>? [[Yes]] (Use: <current collection>; Overwrite: Overwrite <collection A>, <collection B>) [No] . . (Use: <collection A>, <collection B>; Overwrite: <current collection>) Note: 'Default View Settings' isn't great because it doesn't match MediaMonkey's terminology of what a View is. On the other hand, it might be more understandable. |
|
|
Below is an improved approach that allows user to choose collections when multiple collections are shared but don't have identical settings: 1) Config panel within the existing "Select Collections to share settings" dialog (the text appears below the list of Collections, whenever a new sharing relationship is added to the <current collection>): Default View Settings: _<current collection> (Overwrite: <collection A>, <collection B>)__^ <collection A>, <collection B> (Ignore: <current collection>) <collection C> (Ignore: <current collection>) 2) Popup dialog approach (the dialog appears whenever a new sharing relationship is added to the <current collection>) Default View Settings ----------------- Do you want to overwrite <collection A>, <collection B>? [[Yes]] Use: <current collection>; Overwrite: <collection A>, <collection B> [No] . . Use: __<collection A>, <collection B>; Ignore: <current collection>__^ . . . . . . . . <collection A>, <collection B> (Ignore: <current collection>) . . . . . . . . <collection C> (Ignore: <current collection>) |
|
|
I'm prefer 1 ... easy to understand and user will know what exactly happen. |
|
|
Ok, let's implement 1). Just few notes: a. Note that the <current collection> can have an empty title (since it is just being created). In such a case, we should show probably something like 'Current Collection' or find something that's already localized. b. In cases the selection isn't needed (it's already shared and no need to make any decision), the selection should be either disabled or hidden in order to simplify things. |
|
|
Fixed in 1377 |
|
|
Partially tested 1398 and there are several issues: 1) After creating a new Collection and attempting to import settings from Music --> i) The Collection Name is deleted --> ii) The Criteria are not copied --> iii) The Columns all appear empty (i.e. the checkboxes show up, but no text is next to each checkbox!) 2) When creating a new collection, the default Tree Nodes and Columns seem kind of random (I don't understand the logic, at least). I would have expected that they would default to the settings used for 'Entire Library'. |
|
|
Item 1 fixed in 1399. Also tried item 2 and for new collection columns and tree nodes are correctly used same as in Entire Library collection. |
|
|
Others Verified in 1433 Like Petr I could not Replicate 2. |
