View Issue Details

IDProjectCategoryView StatusLast Update
0006665MMW v4Framework: Skinningpublic2010-11-14 04:26
Reporterrusty Assigned To 
PriorityurgentSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version4.0 
Target Version4.0Fixed in Version4.0 
Summary0006665: '-' Appears in Player
DescriptionI'm not sure if this is a bug, a skinning problem, or a problem with the masks describing the format of the currently playing track (I suspect it's a combination of these issues, since the bug appears differently depending on what skin is used--in fact I wonder if it's a bug that skins allow this to be specified, since it will usually conflict with Summary formats as described in 0006571).

For a track in which metadata is missing (e.g. Title exists, but no Album or Artist):
Using the Pulse skin, the following appears: <Title> - -
Using the Vitreous skin, the following appears: Unknown - <Title>

In both cases, I would expect the following to appear: <Title>

According to Frank, the following settings are used for the Pulse skin:
(when no track is select the 2 "-"from mask showing up!

[SongTitle]
Type=Text
Transperent=1
Resizable=1,0,1,0
Pos=129,19
Size=350,18
Transperent=1
TextMask=%S - %A - %L
FontColor=424242
FontHeight=-15
FontName=Calibri
TextAlign=-1
TagsNo tags attached.
Fixed in build1324

Activities

Mizery_Made

2010-11-09 06:49

updater   ~0021267

I think this is a matter of opinion. As my opinion is that the current behavior is appropriate (with perhaps the exception of " - - " appearing when nothing is selected in Pulse) as if it should display "Artist - Title - Album" and there is a title missing and the " - " is omitted, then you end up with "Artist - Album" which could be misleading or result in some confusion as to which fields are being displayed if only two are present when normally there are three for example.

petr

2010-11-09 09:20

developer   ~0021268

I think we don't need to do anything on this part as Frank can use $if command in mask. Like :
%S$if(%A, - ,)%A$if(%L, - ,)%L

rusty

2010-11-09 18:41

administrator   ~0021276

To clarify, the default summary mask should be along the lines that Petr describes.

As far as the skin goes, the Summary object should be used instead of the old SongTitle object (which is being retained for compatibility with older skins). i.e. in the skin's ini file, rename SongTitle to Summary and remove TextMask.

stephen_platt

2010-11-14 04:26

developer   ~0021343

verified 1325