View Issue Details

Jump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0018227MMW 5FileMonitor / Find Missingpublic2021-08-27 13:032021-11-11 21:20
ReporterLudek Assigned To 
PriorityurgentSeverityminorReproducibilityalways
Status closedResolutionreopened 
Product Version5.0 
Target Version5.0.2Fixed in Version5.0.2 
Summary0018227: Add/Rescan: adding hundreds of folders is slow
Description1) Go to Add/Rescan dialog
2) click [Add location...] > select a location with hundreds of subfolders and deselect one of the subfolders (to keep all but one selected)
3) Click [OK]
=> it takes several seconds until the dialog closes
=> folders are added to the list in Add/Rescan dialog, but it also takes up to ten seconds!
4) Click [Scan now]
=> folders are scanned as expected
5) Press Insert to open Add/Rescan dialog again
=> it takes 10+ seconds until the dialog is opened and the hundreds of folders listed
6) try to uncheck or delete one of the folders
=> UI freezes for 10+ seconds until the fodler is unchecked or deleted!
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?p=486243#p486243
TagsNo tags attached.
Fixed in build2501

Relationships

related to 0018214 closedLudek Parent Folder is selected even when a child folder is unselected when adding a Network Location to scanning 
related to 0018215 closedpetr It's easy to add many folders for scanning, but very tedious to remove 
related to 0018052 closedLudek Add Rescan Dialog tweak 

Activities

Ludek

2021-08-27 14:33

developer   ~0064411

Last edited: 2021-08-27 14:34

 Fixed slow closing of dialog after step 3)

But the main problem of slow rendering of Add/Rescan dialog with many folders is in monitoredFoldersView.js > updateMonitoredFolders
It needs to be rewritten to use the concept of binding (like standard ListView descendant) instead of creating hundreds of divs everytime updateMonitoredFolders is called.

petr

2021-09-01 15:10

developer   ~0064460

Fixed

lowlander

2021-09-16 18:57

developer   ~0064680

On Step 3
--> Choose folders dialogs closes fairly quickly
--> Add/Rescan Files dialog took 20+ seconds to populate without any indication to user that it was working on something

peke

2021-09-22 09:04

developer   ~0064806

Test note: I Verified 0018214 fix in 2504, but due the relations I am not sure if 0018214 could introduced regression in this bug behavior.

rusty

2021-10-12 19:36

administrator   ~0065137

User at https://www.mediamonkey.com/forum/viewtopic.php?f=30&t=99839 has indicated that this issue is still present in recent builds. Peke can you verify?

Ludek

2021-10-13 18:32

developer   ~0065173

The user indicated it _before_ this issue has been fixed.

peke

2021-11-11 21:20

developer   ~0065865

Verified regressions and performance in 2518

Unable to reproduce and no regressions popped during testing.