|
|
I see that the [Default icon] ('_icon' in the pictureDataHash) was added by Michal in SVN revision 28073: 0013988: Add possibility to set artist image chosen from user HDD. - finished new find image dialog
It looks like it might be intentional -- to be able to set icon for artists/playlists/albums where user really wish to always see icon -- and not the automatically looked up (or assigned image/collation) ?? |
|
|
|
It is by design, "Default icon" sets this special value, which causes, that artist icon displays default "no image" icon and not use automatic lookup. User can set it, when auto lookup e.g. always finds and assign wrong image for some artist. |
|
|
|
Draki probably means the fact that currently it is impossible to get back from incorrectly looked up image to the default collage (0017031) |
|
|
|
Fixed in 2315.
i.e. reverting to the [Default icon] will show the default collage (0017031) or the default icon (when there isn't any collage). |
|
|
Ludek
2021-02-21 18:43
developer
~0062077
Last edited: 2021-02-21 18:47
|
Re-opened:
Line 1794 in templates.js -- if (item.itemImageType === 'icon') { path = '-';
is still causing that only the icon is shown (and not the collage).
Assinged to Michal to review whether it is safe to change the bahaviour (especially re auto image lookups)
|
|
|
|
Fixed |
|
|
|
Reopen It does not reset to default Icon if Artist have albums and Artist image was already added from one of albums, while there was not enough Album Arts to create Collage even there is enough albums and their Album Arts are fetched with Auto Lookup. |
|
|
|
Another way to replicate is taht if there is an collage on Artist Lookup image and then selecting Default Icon do nothing. |
|
|
|
Note - because of 0017031 "Default Icon" means collage from album artworks and only in case, there are no artworks, display icon. So when collage is made from one artwork, it could look, like nothing changed, it is expected.
I will look at resetting collage. |
|
|
|
Leaving with Michal to triage. |
|
|
|
Resolving, it is not bug. Collage can be done only from 1, 4 or 9 artworks from different albums, Peke had only 3 (the 4th was unsaved suggested artwork only), so the collage was created from one album. I have tested it and once Artists has at least 4 albums with artwork, it creates 4-image collage after choosing "Default icon". |
|
|
|
Thx Michal.
Verified 2315 |
|
