View Issue Details

IDProjectCategoryView StatusLast Update
0016101MMW 5Main Panelpublic2021-03-10 10:12
ReporterLudek Assigned To 
PriorityurgentSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version5.0 
Target Version5.0Fixed in Version5.0 
Summary0016101: Artwork lookup performed even when there is no internet connection
DescriptionBased on some freeze logs (like EDEDD5CB) the artwork lookup is performed even when there is no internet connection.

I tried myself this way:
1) Disconnected from the internet
2) Go to Music > Albums and scroll a lot
=> task queue is full of tasks that takes more than 2 seconds just to fail to download the artwork


From the debug log:
91.03242493 [4104] MM5 [7496](R) TIndyHTTP.GetResponseContent started: URL: https://www.google.com/search?safe=active&tbs=iar:s,ift:jpg&q="Mc%20Erik%20%26%20Barbara"+"U%20can't%20stop%2096%20v"&tbm=isch, RequestBody:
.....
93.40167999 [4104] MM5 [7496](R) TIndyHTTP.GetResponseContent EXCEPTION!!! : Socket Error # 11001

We should use already existing function app.utils.web.isConnectedToInternetAsync() before performing the batch image lookup
TagsNo tags attached.
Fixed in build2212

Relationships

related to 0017652 closedLudek Update api to get internet connection state 

Activities

Ludek

2019-11-08 09:42

developer   ~0055267

Assigned back to me to implement more general solution.

Ludek

2019-11-08 11:04

developer   ~0055268

General solution implemented in 2212

peke

2019-11-15 23:35

developer   ~0055382

Verified 2213

In general MM5 RAM load footprint in 2213 is about 15% less when browsing library that triggers auto lookups, also UI is more responsive due the fact that lest background thread and handles are used.