View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001605 | MMW v4 | Properties/Auto-Tools | public | 2004-11-18 13:19 | 2011-10-25 21:22 |
| Reporter | rusty | Assigned To | |||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Fixed in Version | 4.0 | ||||
| Summary | 0001605: Album Art: Adding image to multiple files via Album Art window only updates the first one | ||||
| Description | If the user selects multiple tracks in the My Computer node, and then _via the Album Art window_ selects 'Add Image': -If the image is being stored to a tag: the image is added only to the first of the selected tracks. -If the image is being linked: the image is added only to the last of the selected tracks The same problem also occurs when the user tries to delete Album Art via the Album Art Window. Note: these problems do not occur if the user selects multiple tracks and tries to add Album Art via the Properties dialog. | ||||
| Additional Information | Reported at: http://www.songs-db.com/forum/viewtopic.php?t=2771 http://www.mediamonkey.com/forum/viewtopic.php?p=47033 Easily reproducible | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 1447 | ||||
|
|
Updated bug description. |
|
|
I think that it is correct, to clarify: Commands in album art window always work on the focused track, i.e. the track with focus rectangle in track listing and the track which album art is displayed in album art window. I don't think it's possible to implement as described because the album art is shown for a particular track, but add/remove commands would work for all selected tracks - would be an inconsistency. A good counter example is when album art is shown for a focused track and user selects many tracks (e.g. all of them using Ctrl-A). Then add/remove command in the window would modify thousands of tracks!! |
|
|
I'm not sure I agree with you, since both I and another user expected that all the selected tracks would be edited. Since the need to edit multiple tracks via this dialog is not that strong (because we now have the ability to edit Album Art of multiple tracks on an album), I would suggest that the problem that needs to be solved is that the user is confused about what is being modified. To solve this problem, we can put the title name in the dialog e.g. Album Art - She Loves You |
|
|
Per IM discussion: Jiri: Track title in AA Title bar could be too long. One suggested means of dealing with this would be to have a dialog pop up asking the user whether or not they want to apply the Add/Remove operation to _all_ selected tracks Russell: A preferred means of dealing with this would be to force the user to the Mass Edit dialog whenever the user attempted to Add/Remove/Edit album art from multiple tracks. That way this would be dealt with in a single/consistent manner. The proposal is described in 0001606. Decision: We'll postpone for now and see if the fixes that allow edits to all tracks on an album deal with this issue sufficiently well. |
|
|
Note: Added dependency on 1606--this bug should be tackled once that one is resolved, in the manner described in the last comment. |
|
|
Might be worth including in 2.5.3 since it's pretty blatant. |
|
|
Pushing--jiri indicated it's not easy/low risk. |
|
|
Resolving for now, since there have been some changes made to the window and some more probably will be. Could be reopened in case it won't be enough. |
|
|
Tested in 4.0.0.1368 and this issue isn't resolved. Tagging album art in the My Computer node fails when the user tries to tag multiple tracks using 'Art & Details' > 'Add Image' (only the first track in the selection is tagged or associated with Album Art). Note: given Jiri's earlier feedback, one possible way of resolving this would be to force the user to select '[ ] Apply to all selected files' (string already exists). |
|
|
Ok, let's add the suggested [x] Apply to all selected files to that Add Image dialog. |
|
|
For consistency fixed in build 1373 by using the fix proposed by Rusty here: http://www.ventismedia.com/mantis/view.php?id=6973#c24982 |
|
|
I've just tested this in build 1446 and I'm a little confused. I expect that when I select multiple files (even if I've selected tracks from separate albums), and add d&d art to the art window (With "Selected" tab), it will add this art to all the selected tracks. And this is really what happens. But, in the pop up dialog it says "[x] Apply to all files in the Album/Series" and _not_ "[x] Apply to all selected files". Is this correct? |
|
|
No, this is not correct, it works as sugested here: http://www.ventismedia.com/mantis/view.php?id=6973#c24982 but only if you add the image via the "Add Image" dialog. The same should happen in case of D&D as you correctly pointed. |
|
|
Fixed in build 1447. |
|
|
verified 1448 |
