View Issue Details

IDProjectCategoryView StatusLast Update
0014709MMW v4Properties/Auto-Toolspublic2018-05-31 20:39
Reporterpeke Assigned To 
PriorityurgentSeveritymajorReproducibilitysometimes
Status closedResolutionreopened 
Target Version4.1.21Fixed in Version4.1.21 
Summary0014709: Album Art: Some Images are incorectly presented
DescriptionBased on User at https://www.mediamonkey.com/forum/viewtopic.php?f=7&t=89522 MMW incorrect decode and show some Image formats
Additional Informationhttps://www.mediamonkey.com/forum/viewtopic.php?f=7&t=89522

https://github.com/JackTrapper/pngdelphi
TagsNo tags attached.
Fixed in build1867

Relationships

related to 0014824 closedLudek Album Art: Metadata update fail on some Album Art upload 

Activities

Ludek

2018-04-03 21:09

developer   ~0049861

Last edited: 2018-04-03 21:10

I see, the issue of darken red color is for the 4bpp.png image (Bit depth 4), isn't issue for 8bpp.png and 24bpp.png

The issue exists in MM5 too

Ludek

2018-04-04 12:19

developer   ~0049862

Last edited: 2018-04-04 12:25

I've tried to update our PNG library from version 1.4361 (year 2003) to 1.564 (year 2006 at https://github.com/JackTrapper/pngdelphi ), but it doesn't solve the issue so I left the old (one as it is customized for MM5). Also by a brief code analyze of the library I haven't found reason for the darken red color.

We could try some alternate PNG libraries (e.g. https://github.com/graphics32/GR32PNG ), but this could be risky to include into 4.1, moving target to MM5...

Ludek

2018-04-04 12:52

developer   ~0049874

Last edited: 2018-04-04 13:05

Finally I found working version of the original library, moving target back to 4.1.21

Ludek

2018-04-04 14:27

developer   ~0049876

Fixed in 4.1.21.1866 and merged into 5.0.0.2094

@Peke, please test on various PNG formats for regressions.

peke

2018-04-09 21:43

developer   ~0049894

Verified 1866 Left resolved till user confirmation.

peke

2018-05-01 02:28

developer   ~0050148

Closing, user also confirmed fix.

peke

2018-05-18 00:22

developer   ~0050327

Reopen for regression check
I uploaded elf file to FTP under "/!TempFiles/bugs_14790and14824and14709.rar" as it looks like there is an regression in PNGImage.pas

Ludek

2018-05-18 11:08

developer   ~0050330

Last edited: 2018-05-18 11:09

I downloaded the rar and extracted, you are probably referring MediaMonkey.elf that crashes in TPngImage?
Based on the log it happened while loading covers of file
G:\mp3\30 Completed\Yeah Yeah Yeahs\It's Blitz!\02-Heads Will Roll-Yeah Yeah Yeahs-It's Blitz!.mp3
Could you please get the file and associated artwork files for me?

Ludek

2018-05-21 18:35

developer   ~0050334

Peke sent me the file over IM, assigned back to me for analyze

Ludek

2018-05-22 12:52

developer   ~0050336

Fixed in 1867.

peke

2018-05-22 22:50

developer   ~0050345

Verified 1867

peke

2018-05-31 20:39

developer   ~0050461

Re verified in 1868 on much larger sample cases.