View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0014486 | MMW 5 | Tagging / organizing (properties / auto-tools) | public | 2017-10-24 13:21 | 2022-08-27 02:02 |
| Reporter | jiri | Assigned To | |||
| Priority | urgent | Severity | major | Reproducibility | N/A |
| Status | closed | Resolution | reopened | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0.4 | Fixed in Version | 5.0.4 | ||
| Summary | 0014486: Auto-tag fields selection | ||||
| Description | Currently there's a selection of auto-tagging fields implemented. However, it's shared by audio and video, which results e.g. in a Director field shown for audio tracks. We probably should split this configuration and make it separated for Audio and Video. Btw, the configuration should rather need just one line for each type and open a separate dialog for the individual checkboxes (just like implemented e.g. for Sources below). | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2661 | ||||
|
|
Fixed |
|
|
1. Audio tagging shows Publisher field as a column, while it isn't configurable!? 2. Automatic column width settings doesn't persist. 3. I wonder, since this dialog has Choose Columns dialog available on right click, it might also be used for tagging columns selection? I.e. the column that's shown is used for tagging? It probably still could be available from the Options. Note that currently the usage of Choose Columns results in somewhat lost columns in the Auto-tag dialog. |
|
|
Fixed |
|
|
2. It persists now, but only when the dialog is confirmed by OK. I think that these changes should persist in any case, since OK is supposed to only confirm the auto-tag operation, not the dialog configuration. 3. There's still quite a mismatch between the 'Choose columns' dialog from the header and the Select fields dialog from Auto-Tag Options. E.g. fields hidden by the 'Choose columns' dialog and shown the next time the Auto-Tag dialog is shown! I suppose that the visible fields should be the same as the fields that are to be tagged, i.e. the 'Select' button in Options should show the Choose Columns dialog, instead of the custom 'Choose fields' dialog? 4. The headers and the content below are few pixels off (content moved a bit to the right). 5. Track # fields are always highlighted, even though already tagged correctly. I suppose that they should be highlighted only when the new and old values are different? |
|
|
Fixed |
|
|
4. Still not perfect here. 6. It'd be nice to also have Path as a possible Column, so that it's easier to identify which track is actually being tagged. We might consider few other fields, in order to help user to better see what'd going on - possibly Length and Bitrate? 7. Album cover often shown incomplete until its column is resized. E.g. enlarge this column, close the dialog and open it again => the bottom of the cover isn't shown. |
|
|
Items 4 & 6 fixed |
|
|
Fixed |
|
|
There are still several outstanding issues with this (some originally reported at item ww in #14224): 1 There's still a mismatch between fields that are configured and fields that are shown: a) The following fields that can be added, but don't get looked up (tested with tracks from 50 different albums): Involved people, Publisher, Producer, Lyricist, Comment b) The following fields have no entry but always appear: Album Artist, Year, Date, Length, Path c) Adding/removing fields for Audio causes the same field to be added/removed for Video. 2 When adding a new field, the default column width is much too wide a) for small fields such as Track #, the width is about 20-30 characters too wide b) for wide columns such as Genre, the column width expands dynamically causing 'Genre' in some cases to take up half the screen thereby obscuring other columns. The column widths shouldn't adjust dynamically if this is the result. 3) Re. the functionality of adding/removing columns _within_ the Auto-tag dialog (via right click): b) it should be limited to columns that are supported by Auto-tag functionality or that always contain data (e.g. time, bitrate, path). c) if a field is enabled, then the auto-looked up data for that field should be shown 4) Fields don't display in the order that they appear in the options (and vice versa) |
|
|
re 1b) Album Artist column is shown together with Album column (album is checked in fields selection). 1a, 1c, 2, 3, 4 fixed |
|
|
Tested 2152 and it's much improved. The following issues remain: 1 a) Fields that don't get looked up: i) Producer and Lyricist are still available as options, but upon testing 75+ tracks, not a single one was updated with Producer or Lyricist! ii) Lyrics. If enabled nothing seems to happen. Also: - It can't be enabled/disabled as a column. It should be. Moreover, it should be enabled/disabled like all other metadata fields (via the chooser). - There should be a means of examining/re-looking up/editing the lyrics within the auto-tag dialog b) Columns with no entries: i) The Album Art column doesn't seem to have an entry to hide it. Presumably this is because '[x] Artwork is enabled independently of all other fields. It probably would make sense to treat both Lyrics and Artwork the same as other fields (i.e. enable them within the chooser). This would also solve the problem of user confusion that occurs when Album Art is looked up even if the Album Art lookup is disabled (i.e. it's not really a problem that MM looks up Album Art, but it is a UI inconsistency if it gets looked up and displayed to the user since the user thinks that it'll be tagged upon clicking 'Tag & Continue'). ii) Album & Album Artist doesn't have an entry. It currently appears within 'Custom' as "". I guess this is tricky because we don't want a header to display for this field. 3c) Dsplay of data for newly enabled fields doesn't seem to be fixed and can be replicated via either of the following means: i) Enabling a field via the column chooser ii) Enabling a field via the 'Options' button e.g. 1 Disable the Genre field in the auto-tag dialog 2 Auto-tag a track that is known to result in a Genre lookup 3 Enabled the Genre field (either via the Column Chooser OR via the Options button --> In both cases MM doesn't update the dialog with the new Genre (and in the latter case, it doesn't even display the column). The user would expect that if the field has been looked up, then it should display OR if it hasn't, there should be a refresh button to retrigger the lookup. |
|
|
Items ai, aii, 3c fixed item 2) i've enabled Album column in columns selection so it can be hidden. Also removed 'Album & Album Artist' from columns selection as it's behave as group column without any description and it's better to hide from selection than have it as '' (empty string). |
|
|
Tested 2167, and much improved, but still a few issues: 1a ii) Configuration re. lyrics metadata lookup should be in the same location as all other audio tags (I don't see any reason for separating it). 2) It's still really unclear what the [ ] Artwork checkbox does, since currently if the user unchecks it, auto-tag still attempts to look up artwork! I would suggest that: i Configuration re. Album Art lookup should be separated for Music vs Video ii It should be enabled by default (as it is now) for both iii) If it's disabled, then the Album Art shouldn't be looked up (it could still optionally display). 3) The behavior of the changing Metadata Lookup options is still very unclear e.g. a) If the user does a lookup and changes the options: i) adds a field: ---> MM doesn't update the view to include the new field (so it's unclear to the user whether it's been looked up)!! ii) removes a field: --> MM doesn't eliminate the looked up metadata from the field (making it appear as if it'll be tagged despite it having been disabled)!! b) If the user does a lookup and changes the columns: i) adds a field e.g. 'Genre' that isn't configured to be looked up: --> MM looks up the field and displays it (OK, but inconsistent with 3ai) ii) removes a field --> unclear whether the field has been removed from the view or whether it has been disabled ! So I'm going to revert my earlier suggestion and suggest that whether Fields are displayed in this view should not affect whether or not Fields are updated (i.e. only the Options panel should affect whether fields are looked up), AND: a i) if the user adds a field in Options --> MM should also enable the field in the auto-lookup window a ii) if the user removes a field in Options --> MM shouldn't remove it from the view, but should no longer suggest metadata updates for the field in question b i) if the user adds a column --> column gets added b ii) if the user removes a column --> column gets removed c) In the options change text to make the suggestions above more clear: Columns --> Tags Selected columns --> Tags to look up 4) Not an issue since it's now obvious that there's a need to display columns even if they're not being looked up. 5) D&D of fields in the Options --> they disappear if they're not dragged directly onto the opposing column |
|
|
Fixed |
|
|
Tested 2168 and there are still some issues: 3) There's still some strangeness in the relationship between the settings via 'Options' , what actually gets tagged, and what appears in the columns in the auto-tag dialog: ai) Adding a field to Options --> The field doesn't display in the auto-tag window! aii) If a field has been removed from Options--> it still gets tagged!! (tested with 'Album') c) The dialog is still titled 'Choose columns' . It should be changed to 'Choose fields' 5) D&D of fields from 'Tags to look up' to 'Tags' sometimes still sometimes causes the fields to disappear from the 'Choose columns' dialog! It's not consistent, but it's easy to replicate by D&D a field back and forth a few times between the two columns. 6) a) There's a regression re. fields appearing as if they've been looked up (i.e. colored), even if they haven't. e.g. For a track that already has a 'Year', initiate a lookup that results in the same year appearing --> the year appears colored! (tested with 'Ships in the night' - 'Be Bop Deluxe') b) If a field has been removed from Options but still exists in the Auto-tag dialog (e.g. because it was _previously_ looked up), then fields that aren't going to be tagged should appear greyed out (currentlly they appear in orange as if they're going to be tagged) . 7) Assuming that grouping works for both tracks and episodes, should we make the following change? Group tracks within a single album if possible --> Group items within a single album/series if possible EDIT: deleted item 8) re wording of fingerprinting option since it is superceded by #14571 |
|
|
Fixed |
|
|
I haven't verified the fixes to-date, but as noted by LL (at 0017216), issue 3) isn't fixed: 3aii) Album is updated even if the field is disabled (Although the Album column is hidden, the change of Album is highlighted in the Summary column)! iii) Similarly with other fields e.g. year, disc#, track#: the column appears even when the field is disabled and the associated metadata is looked up! |
|
|
Just tried on current sources and only selected fields are changed (removed album, track#, disc# from selection and non of them were changed) |
|
|
Tested 2286. Setting to 5.0.1 since the remaining issues are relatively minor (even though they're likely trivial to fix): 3)aii) I was mistaken--it's actually only the Album field that's always looked up. The simplest fix might be to have a hardcoded 'Album Summary' entry (that can't be disabled) in the Options > Auto-tag settings. Since it's currently always looked up, the UI should reflect that. Re. the functionality of adding/removing columns _within_ the Auto-tag dialog (via right click): The actual implementation has ended up being that the fields that are displayed don't necessarily match up to the fields that are looked up. e.g. b) The following fields: Comment, Lyricist, Publisher, Producer, Parental Rating can be enabled though they can't be looked up. This seemingly random selection of fields probably shouldn't appear. c) fields such as Genre can be disabled (by right-clicking on the auto-tag headers) even though they're chosen to be looked up OR can be enabled even if they're chosen to not be looked up, however, this is a really minor issue since that setting isn't persisted (i.e. if Genre is enabled for auto-tag, then on the next auto-tag operation, the field appears). I think that the real solution is to just disable the ability to configure which auto-taggable fields should appear. |
|
|
Fixed ... summary column cannot be removed and fields selection is disabled in auto-tag dialog. |
|
|
Verified 2661 |
