View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010287 | MMW 5 | General | public | 2012-12-25 23:11 | 2022-10-21 18:22 |
| Reporter | peke | Assigned To | |||
| Priority | urgent | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 5.0 | ||||
| Target Version | 5.0 | Fixed in Version | 5.0 | ||
| Summary | 0010287: Repeat Single Track | ||||
| Description | Especially as we have this ability in MMA it could be usable to add this to MMW also. This should not be too hard to add. Feature requirements: - AutoDJ is ignored when enabled - Continuous is ignored - Works in shuffle UI: - Context menu on Repeat button (Repeat one, Repeat All, Repeat off) Skinning Framework: - Additional Repeat button (See Bellow for definition) - Compatibility with MM 4.0 skins it will show same enabled repeat button if dedicated button do not exist - Additional Button Type Support 0010288 | ||||
| Additional Information | TNZ-703-30804 | ||||
| Tags | No tags attached. | ||||
| Fixed in build | 2238 | ||||
|
|
Definitely useful, especially considering that the extension for this functionality in MM4 won't work. But I wouldn't want to extend MM 5.0 development further, so leaving it to Ludek's discretion. Workflow would be something like: 0 Play track 1-5, currently playing Track 3 1 Click 'Repeat' button to toggle 'repeat 1 track' / 'repeat all' / off --> MM repeats track 3 once --> MM then automatically toggles back to Repeat:off and track 4 starts playing Note: this type of implementation would preclude Repeat1x from being used while Repeat All is enabled. |
|
|
I have never understood how "repeat one" could be useful? I can imagine that I am a musician and want to practice one song (and have it repeated continuously), but in that case I can have just this single song in Now Playing queue and have Continuous enabled. So it is feasible currently, or am I missing something? And if someone wants to repeat single track just once then he can right-click the track in Now Playing and use > Play Next BTW: By testing this I found 0016442 that should be fixed for 5.0 As for the implementation suggested by Rusty: I can uderstand that it should be toggle ['repeat 1 track' / 'repeat all' / off] as it is how most of players have it implemented. I just don't understand why MM should automatically toggle back to Repeat:off and track 4 starts playing ?? --------------------------------------------- EDIT: Note that once we add it as toggle then I suppose that also some wording changes will be needed, especially in the menu Play where current [ ] Continuous needs to be replaced by Repeat > (o) off .................( ) 1track .................( ) all tracks ? ------------------------------------ EDIT2: LowLander also suggested to enhance "Stop after current" to a toggle like: "Stop after: [current file, every file, off]" Saying that users who use MediaMonkey in dance/music teaching scenarios find this useful as they're often not at the PC to do this themselves. |
|
|
1) Re. continuous playback, I agree. i.e. If enabled, it should play the given track endlessly. a) As far as the suggested wording, it could be simplified further to Repeat: off, one, all. b) As far as icons, 'one' can be the current icon with a '1' in the middle. 2) As far as 'Stop after' changes, sounds good as long as there's a clear indication that Stop after: every file is enabled (otherwise users can get into a situation where they don't understand why MM is behaving this way. The status should be obvious in both the Context menu and the Player itself. One possible approach is to display the 'Stop' button whenever this function is used (even if it's disabled in layout), but display it differently (e.g. with timer notches around the circle). 3) Separate issue, but mentioning it here since you're already going to be making changes to the Player context menu: a) Move 'visualization' to the bottom of the 'Sleep'/'Equalizer' section b) Move 'Layout'/'Options' below Properties |
|
|
ok, assigned to Michal for implementation (time permitting), but if we want to include it in 5.0 then we should probably do this ASAP because fo the wording changes |
|
|
2) To Make it consistent I would suggest that in case Stop After current is enabled Play Icon Have Small Stop icon Overlay as a Sub Function of playback. Which object we can Possibly later use it for other playback features Like when Auto DJ is Enabled or when there is a sleep timer. Note: If we go with this approach it will be easier for Skin/Script Designers to reflect it on Player state. |
|
|
1) and 3) fixed in build 2235. |
|
|
2) fixed in build 2235. For indication used corner of Pause button, could be enough. |
|
|
Tested 2235: 1) It currently not clear what the current state the toggle is in: a) I would suggest something like Repeat: <current state> [next state, next state] . e.g. Repeat tracks: off [one, all] b) If Repeat one track is the current state, then the icon should appear with the number '1' in the middle [EDIT: Note: it might be a skinning problem--I just noticed that there are now duplicate versions of every skin in my installation (though I've just tested both versions of the Material Design Dark skin and neither works). Strangely, when I switch to Black Monkey, the 'Stop after' indicator shows (regardless of which version of the skin I select), but 'Repeat One' doesn't. See: https://www.screencast.com/t/2yIgsHU2WL ] 1c) If 'Repeat:one' is enabled, and the user presses 'Next', they'd expect that the next track start playing (rather than repeating the current track). 2) The functionality seems to work as expected, however there's no indication in the player that tracks are going to stop (tested with Stop button enabled / disabled) 3) Verified |
|
|
Note regarding the Skinning problem: - Clean install of 2235 doesn't exhibit the problems (no duplicate skins, repeat/stop icons display) - Clean install of 2234 + upgrade to 2235 doesn't exhibit the problems So I'm not sure what in my environment triggered the problems. |
|
|
1c) fixed in build 2236. The rest should be fixed too by improvement in upgrading procedure. |
|
|
Tested 2236: 1b)/2) Still not resolved in my environment and occurs exactly as previously reported (i.e. deplicate skins still display; no new repeat/stop icons for Material Design (dark) which is the skin I regularly use; No new stop icon for other skins). This is now being tracked at #13184 (that's where the problem arose). 1c) If the user presses 'Next' while 'Repeat One' is enabled --> Next track starts playing as expected, but the NP List (in the right column) continues to highlight the original track instead of the now playing track. |
|
|
Skin issue fixed. Problem with highlighting not reproduced, please retest with version with fixed skin. |
|
|
Closing (can't replicate 1c with build 2237). |
